Squiz/OperatorBracket: prevent PHP notices during live coding #580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Squiz/OperatorBracket: rename test case file
.... to allow for adding additional test case files.
Squiz/OperatorBracket: prevent PHP notices during live coding
During live coding (or in the case of parse errors), the "end of the expression" cannot always be correctly determined. In such a case, the sniff should stay silent.
This wasn't always handled correctly so far and could lead to the following PHP notices:
This commit fixes these by adding some extra defensive coding and bowing out when an unclosed bracket set is encountered.
Includes tests.
Suggested changelog entry
Squiz.Formatting.OperatorBracket: bug fix for potential PHP notice during live coding
Related issues/external references
Loosely related to #152 as this issue was discovered when creating an update for the fixer conflict list.
Types of changes